Makefile gcc line shows /usr/include -I/usr/include

[jimnewell]

In the makefile, the -I is missing after -O2 and
(actualy) the /usr/include is duplicated:
gcc -o channel.o channel.c -c -g -O2 /usr/include
-I/usr/include -Wall -I../incl ude/ -fPIC

Deleting the duplicated /usr/include fixes the problem.

System is: Redhat Entererprise 4
Linux localhost.localdomain 2.6.9-34.EL #1 Fri Feb 24
16:44:51 EST 2006 i686 i686 i386 GNU/Linux

Actual output from make process:
[root@localhost libssh2-0.14]# make
make[1]: Entering directory
`/home/jnewell/dev/LibSSL/libssh2-0.14/src'
gcc -o channel.o channel.c -c -g -O2 /usr/include
-I/usr/include -Wall -I../incl ude/ -fPIC
gcc: /usr/include: linker input file unused because
linking not done
channel.c:1253:10: /usr/include: No such file or directory
channel.c:71: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://bugzilla.redhat.com/bugzilla> for
instructions.

[anonymous]

Logged In: NO

The basic cause of the problem is an error in setting
OPENSSL_INCLINE from the pkg-config output.

This patch fixes it:
--- configure
+++ configure 2006-07-30 13:03:39.000000000 +0200
@@ -3739,7 +3739,7 @@

found_openssl=yes
pkgcfg_openssl=yes
OPENSSL_LIBLINE=$PKG_CONFIG --libs openssl

• OPENSSL_INCLINE=`$PKG_CONFIG --variable=includedir

openssl`
+ OPENSSL_INCLINE="-L`$PKG_CONFIG --variable=includedir
openssl`"

echo "$as_me:$LINENO: result: Using paths from

pkg-config" >&5

echo "${ECHO_T}Using paths from pkg-config" >&6
fi

[anonymous]

Logged In: NO

The same problem occurs on on FreeBSD 6.1-STABLE:

===> Building for libssh2-0.14
cc -o channel.o channel.c -c -O2 -fno-strict-aliasing -pipe

/usr/local/include -I/usr/include -Wall -I../include/ -fPIC

cc: /usr/local/include: linker input file unused because
linking not done
channel.c:1253:10: /usr/local/include: No such file or directory
* Error code 1

Stop in /usr/ports/security/libssh2/work/libssh2-0.14/src.
* Error code 1

[bschell]

patch is not quite right.
The OPENSSL_INCLINE setting should be:

OPENSSL_INCLINE=-I$PKG_CONFIG --variable=includedir openssl

rather than:

OPENSSL_INCLINE="-L$PKG_CONFIG --variable=includedir openssl

note the '-I' instead of the the '-L'

[bagder]

this problem is fixed in CVS