Ticket #43 (closed defect: fixed)

Opened 10 years ago

Last modified 22 months ago

data type for offset in libssh2_sftp_seek

Reported by: anonymous Owned by: bagder
Priority: normal Milestone:
Component: API Version:
Keywords: Cc: bagder
Blocked By: Blocks:

Description

The data type for the offset in libssh2_sftp_seek() should be libssh2_uint64_t, not size_t, because size_t is probably limited to 32bit. The internal variable for the offset has the correct data type.

The prototype should be:

LIBSSH2_API void libssh2_sftp_seek(LIBSSH2_SFTP_HANDLE *handle, libssh2_uint64_t offset);

Change History

comment:1 Changed 10 years ago by bagder

I can only agree, unfortunately this will break the ABI and thus require another SONAME bump...

comment:2 Changed 9 years ago by bagder

I've now added a libssh2_sftp_seek2() function in CVS that supports large file seeking. Thus it doesn't break the ABI with older existing releases!

comment:3 Changed 22 months ago by Zenju <zenju@…>

  • Resolution set to fixed

In 3768f8aeef9faa009a2c056beacaa566bd90013e/libssh2:

kex: free server host key before allocating it (again)

Fixes a memory leak when Synology server requests key exchange

Closes #43

Note: See TracTickets for help on using tickets.